fix(smb errors): getErrorString only returns one item, not a tuple

[Marshall-Hallenbeck]

fixes #117

[XiaoliChan]

variable desc was use in logger

NetExec/nxc/protocols/smb.py

Line 447 in 1784d55

f"{domain}\\{self.username}{used_ccache} {error} {f'({desc})' if self.args.verbose else ''}",

[Marshall-Hallenbeck]

variable desc was use in logger

NetExec/nxc/protocols/smb.py

Line 447 in 1784d55

f"{domain}\\{self.username}{used_ccache} {error} {f'({desc})' if self.args.verbose else ''}",

Good catch, looks like we should fix this everywhere. getErrorString() returns just a string, not a tuple, so I guess Impacket changed?
We should probably handle all these errors natively through Python, and not use Impacket's functions...

[NeffIsBack]

variable desc was use in logger

NetExec/nxc/protocols/smb.py

Line 447 in 1784d55

f"{domain}\\{self.username}{used_ccache} {error} {f'({desc})' if self.args.verbose else ''}",

Good catch, looks like we should fix this everywhere. getErrorString() returns just a string, not a tuple, so I guess Impacket changed?

We should probably handle all these errors natively through Python, and not use Impacket's functions...

Can you check that somehow in impacket? It's really surprising to me that this obvious fault should be that long in the code without us running into it

[Marshall-Hallenbeck]

@NeffIsBack they changed it in Impacket: fortra/impacket@33058eb

[Marshall-Hallenbeck]

Holding off on this fix until we hear back from fortra/impacket#1311

Currently it should be working in main since @mpgn reverted the gdki branch update to their master branch.