Removing deprec… #132
Merged
Removing deprec… #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated encodeerror check
NeffIsBack
requested review from
zblurx,
Marshall-Hallenbeck and
mpgn
as code owners
|
why the .lock is updated in this pr ? |
|
I thought it needed an update to fetch the newest changes from our impacket fork, but it seems like it only checks sha sums etc. when fetching from pypi or a new version is introduced. Gonna reset the lock file |
mpgn
approved these changes
Dec 17, 2023
NeffIsBack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ated encodeerror check
This will finally fix #129 and similar issues. Also removing the encoding error check as this should not happen anymore