Fix issue #134 with tempfile on windows #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeffIsBack
requested review from
zblurx,
Marshall-Hallenbeck and
mpgn
as code owners
|
This is specific to windows ? |
Yes, crashing on windows but working flawlessly on linux |
mpgn
reviewed
Dec 17, 2023
mpgn
approved these changes
Dec 17, 2023
|
Ran tests and they passed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #134:
Tempfile adds a handy attribute to the file which deletes the file after closing. This prevents sqlite3 on windows to connect to the file unfortunetly. This is to be expected according to the documentation https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile
In python 3.12 there is apperently a better solution, but for now removing the file manually is probably the best solution