Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: iis module cmd exec quotes #146

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix: iis module cmd exec quotes #146

merged 1 commit into from
Dec 15, 2023

Conversation

0xlazY
Copy link

@0xlazY 0xlazY commented Dec 13, 2023 •
edited
Loading

Came across a quote issue with the IIS module and the command was failing, thus not parsing any data.
Inverted " with '

quote_fix_ncx

@NeffIsBack NeffIsBack added bug-fix This Pull Request fixes a bug reviewed code Label for when a static code review was done tested labels Dec 14, 2023
NeffIsBack
NeffIsBack approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeffIsBack NeffIsBack merged commit ef4f2df into Pennyw0rth:main Dec 15, 2023
1 check passed
@0xlazY 0xlazY deleted the iis_quote_fix branch December 26, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeffIsBack NeffIsBack NeffIsBack approved these changes

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

@Marshall-Hallenbeck Marshall-Hallenbeck Awaiting requested review from Marshall-Hallenbeck Marshall-Hallenbeck is a code owner

@mpgn mpgn Awaiting requested review from mpgn mpgn is a code owner

Assignees
No one assigned
Labels
bug-fix This Pull Request fixes a bug reviewed code Label for when a static code review was done tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xlazY @NeffIsBack