add argcomplete bash/zsh completion #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamkadaban
requested review from
zblurx,
Marshall-Hallenbeck,
NeffIsBack and
mpgn
as code owners
|
I really like it! I also fixed the completion for modules, so you also can tab-to-complete them as well. Gonna push the fixes now |
|
@NeffIsBack Nice! Thanks for the help |
|
|
NeffIsBack
added
tested
reviewed code
|
@Adamkadaban if you have the time it would be nice if you PR the setup guide to the wiki :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to move
len(sys.argv) == 1check after parsing args to make sure autocomplete can run the program correctlyUsers can get completion by running
eval "$(register-python-argcomplete nxc)"if they want tab completionThis is something that I can add to the wiki if the PR gets approved