Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues in deps #162

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

thiagokokada
Copy link
Contributor

We are trying to package this in nixpkgs (see NixOS/nixpkgs#279879), and found some issues in the pyproject.toml. So this PR fixes them.

Introduced in 483dc69, it points to
https://github.com/RussellLuo/resource, an unmaintained library.
However, it is clear in the code that this should have been resource
from stdlib instead (https://docs.python.org/3/library/resource.html),
and needs not to be included in `pyproject.toml`.
@NeffIsBack NeffIsBack added dependencies Pull requests that update a dependency file tested reviewed code Label for when a static code review was done labels Jan 15, 2024
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeffIsBack NeffIsBack merged commit 9df72e2 into Pennyw0rth:main Jan 15, 2024
1 check passed
@thiagokokada thiagokokada deleted the fix-some-issues-in-deps branch January 15, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file reviewed code Label for when a static code review was done tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants