Remove pyreadline as it causes errors in nxcdb #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeffIsBack
requested review from
zblurx,
Marshall-Hallenbeck and
mpgn
as code owners
|
Did you test the build to check? Because when I was making the builder it was throwing an error without it. |
|
I did, but didn't get an error. Can you revalidate tho, if you still get one? |
Marshall-Hallenbeck
force-pushed
the
neff-rem-pyreadline
branch
from
a39f71e to
0d1c8bc
Compare
|
Building locally now on my Win11 machine |
|
Installed dependencies via |
Marshall-Hallenbeck
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170 and errors pointed out on discord. Pyreadline is probably not used by impacket anyway.