Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BloodHound & hash_spider fixes #226

Merged
merged 3 commits into from
Mar 23, 2024
Merged

BloodHound & hash_spider fixes #226

merged 3 commits into from
Mar 23, 2024

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

@Marshall-Hallenbeck Marshall-Hallenbeck commented Mar 22, 2024

@Marshall-Hallenbeck Marshall-Hallenbeck added the bug-fix This Pull Request fixes a bug label Mar 22, 2024
@Marshall-Hallenbeck Marshall-Hallenbeck self-assigned this Mar 22, 2024
@NeffIsBack
Copy link
Contributor

Imo why shouldn't just exit when bloodhound fails to authenticate. In realworld pentests it would maybe be annoying if you get spammed with failed authentication messages, but still better than straight out shutting down your (potentially crucial) command execution over numerous hosts.
In the end it's just a connector trying to assist with bloodhound enumeration.

Rest looks good👍🏼

@Marshall-Hallenbeck
Copy link
Collaborator Author

It throws tons of errors and will cause you to rerun it all again if you don't notice it at first. If we fail out right away they can fix the issue or just turn off Bloodhound integration, a much more simple step than potentially having to reauth against thousands of hosts.

@NeffIsBack
Copy link
Contributor

Well okay, probably not such a big deal anyway.

Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't explicitly test but there is not much that could go wrong, LGTM👍🏼

@Marshall-Hallenbeck Marshall-Hallenbeck merged commit d8284f9 into main Mar 23, 2024
2 checks passed
@Marshall-Hallenbeck Marshall-Hallenbeck deleted the issues/221 branch March 23, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in hash_spider module: 'database' object has no attribute 'get_computers'
2 participants