Fix testing and linting #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeffIsBack
requested review from
zblurx,
Marshall-Hallenbeck and
mpgn
as code owners
|
Tests are failing because the few tests I created in |
|
Ah yeah i just wanted to have something that checks that installations are working on every platform and with every supported python version. Maybe just disable the |
|
Yeah, I would get rid of that part, and just do the install. Maybe run the binary with -h after, to make sure stuff loads? |
|
Sounds good! |
Marshall-Hallenbeck
approved these changes
Mar 30, 2024
.github/workflows/test.yml
Outdated
| - name: Install libraries with dev group | ||
| run: | | ||
| poetry install --with dev | ||
| - name: Run the e2e test |
There was a problem hiding this comment.
This isn't the e2e tests, that's ran directly via the e2e_tests.py file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we build with every python version which we support on approval and lint on every push (pull_request was redundant)
Also the test runner will now test if the installation on the platform is able to load every protocol and module:
Note: As I tested a bit this probably should get squashed merged