Add git commit to version command

[Marshall-Hallenbeck]

• add git commit to version command so we know exactly what code is being ran during issue triage

[NeffIsBack]

Crashing on my end

[NeffIsBack]

That's what importlib.metadata.version("netexec") returns for me

[Marshall-Hallenbeck]

You need to install the poetry_dynamic_versioning dependency.

[NeffIsBack]

Hmm I will try again, but I just did poetry install and then poetry run

[NeffIsBack]

@Marshall-Hallenbeck fresh installation:

[NeffIsBack]

Huh, pipx works fine

[Marshall-Hallenbeck]

When I pull down a fresh repo and run it via poetry, this all works for me.

@zblurx @XiaoliChan could you guys test this as well?

pull down this branch/a new repo, then run:

poetry lock --no-update
poetry install
poetry version
poetry run nxc --version

[NeffIsBack]

Did you try to reinstall poetry? My guess is still that this is set in poetry

[Marshall-Hallenbeck]

Did you try to reinstall poetry? My guess is still that this is set in poetry

No, I'll try it on another host, too.

[Marshall-Hallenbeck]

Hmm so yeah it looks like this doesn't work for normal poetry install, unless we distribute the package built with poetry build.

I'll have to figure out how to hook it into that process if I can...

[Marshall-Hallenbeck]

this works for pip/pipx since its respects the build-system, but poetry unfortunately doesn't (at least that's what it appears like: python-poetry/poetry#6154)

[Marshall-Hallenbeck]

@NeffIsBack so right now, pip/pipx will properly use the versioning, but poetry doesn't respect the build-system section, which is annoying.

Luckily most people just install via pipx, and we really care about this for them when users report issues, so I think it's in a current state to help us out in that sense.

I reverted to define the version # in the pyproject, so we will continue to update that with the latest tag, but we also get the bonus of getting the actual commit when someone uses pip/pipx.

[Marshall-Hallenbeck]

Should the COMMIT just be a blank string, or should we put like "None". This is really only applicable when someone uses poetry to install (developing), and they should be able to easily tell what the latest commit is anyway. It just sorta looks meh on output:

[NeffIsBack]

Imo "" is fine, although its bothering if you know, most of the people will probably never notice it :D
None could be confusing

[NeffIsBack]

I also opened an issue on the plugin repository: mtkennerly/poetry-dynamic-versioning#176
Maybe they can help

[NeffIsBack]

@Marshall-Hallenbeck how about we add it also to the debug output, so we know which commit people are running when they open up issues?

[Marshall-Hallenbeck]

@NeffIsBack I've updated how we parse the args a bit, to parse debug and verbose early, so we can now properly debug log in the parsing of other CLI args. I also functionized/moved some stuff to logging to better fit our needs.

Now we can output info like this:

or even just if someone wants to debug the -h option, etc:

[NeffIsBack]

LGTM