[ssh] improvement

[XiaoliChan]

Totally bugs fixed & improvement:

• [ssh.py]: less create ssh connect, keep doing set credential via paramiko transport
• [ssh.py]: rewrite enum_host_info function
• [ssh.py]: fix hanging, old one will never exit
• [ssh.py]: fix private key with passphrase
• [ssh.py]: add sudo check for linux user
• [ssh.py]: windows privileges check
• [ssh.py]: improve command execute and format command execute result
• [ssh.py]: paramiko always discovery private keys in ~/.ssh/, that will make paramiko exception, disable it.

[Marshall-Hallenbeck]

Will need to actually test this as well

@XiaoliChan can you also add new e2e tests in the command list for the new options you've added?

[XiaoliChan]

Will need to actually test this as well

@XiaoliChan can you also add new e2e tests in the command list for the new options you've added?

Sure!

[NeffIsBack]

Linux works 👍

Tho it would be nice if you could change the syntax back to for example "(Pwn3d!) - (root/non root) Linux - Shell access!"

[XiaoliChan]

@NeffIsBack @Marshall-Hallenbeck I will solve the issues in reviews after my holiday :D

[NeffIsBack]

@NeffIsBack @Marshall-Hallenbeck I will solve the issues in reviews after my holiday :D

Take your time and enjoy your holidays :D

[XiaoliChan]

Tho it would be nice if you could change the syntax back to for example "(Pwn3d!) - (root/non root) Linux - Shell access!"

Done, I changed it to this

[XiaoliChan]

Confirm the private key with passphrase login works

[NeffIsBack]

Windows working for me 🎉

[NeffIsBack]

There are still some single quotes instead of double quotes :)

[NeffIsBack]

Everything is working now. Great job @XiaoliChan

There are still a few single quotes but we wait until #35 is merged, probably a lot are already fixed there

[NeffIsBack]

Have to revoke approval, ssh with keyfile is no longer working from linux to linux

[NeffIsBack]

Have to revoke approval, ssh with keyfile is no longer working from linux to linux

Further investigation:
having ssh keyfiles in the ~/.ssh directory leads ssh to crash

[XiaoliChan]

Further investigation: having ssh keyfiles in the ~/.ssh directory leads ssh to crash

Fixed!

[NeffIsBack]

Everything working now 👍

[NeffIsBack]

@Marshall-Hallenbeck this is ready as well, should i merge it or are we waiting for your PR?

[Marshall-Hallenbeck]

@NeffIsBack we can probably merge this, I still have to fix some of the things from your feedback for #35