Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Build Actions for Releases #27

Merged
merged 11 commits into from
Sep 19, 2023
Merged

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

No description provided.

Signed-off-by: Marshall Hallenbeck <Marshall.Hallenbeck@gmail.com>
@Marshall-Hallenbeck Marshall-Hallenbeck added this to the v1.0.0 milestone Sep 18, 2023
@Marshall-Hallenbeck Marshall-Hallenbeck self-assigned this Sep 18, 2023
@Marshall-Hallenbeck
Copy link
Collaborator Author

Looks like it all built!

https://github.com/Pennyw0rth/NetExec/actions/runs/6228635143/job/16905726104

@Marshall-Hallenbeck Marshall-Hallenbeck marked this pull request as ready for review September 18, 2023 22:51
@Marshall-Hallenbeck
Copy link
Collaborator Author

But the windows binary crashes at runtime. More testing needed.

@Marshall-Hallenbeck
Copy link
Collaborator Author

Build went through (https://github.com/Pennyw0rth/NetExec/actions/runs/6238351109) and @NeffIsBack and I both confirmed the native Windows exe runs for us.

@NeffIsBack should be good for your approval!

Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marshall-Hallenbeck Marshall-Hallenbeck merged commit b6f6f19 into main Sep 19, 2023
5 checks passed
@Marshall-Hallenbeck Marshall-Hallenbeck deleted the github_builder branch September 19, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants