Fixing #263 #271
Merged
Fixing #263 #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fix bug where bool instead of None would be returned
NeffIsBack
requested review from
zblurx,
Marshall-Hallenbeck and
mpgn
as code owners
|
Can you check with a result ? |
|
Oh yeah sorry, forgot that |
mpgn
previously approved these changes
Apr 21, 2024
|
Glad we have the checks for the python version. It catched an incompatibility issue with datetime and python <3.11 |
mpgn
previously approved these changes
Apr 21, 2024
|
Spoke with @NeffIsBack, I think catching that exception and having a proper error would be nice to let users know what the problem is instead of a stacktrace |
|
Updated to: |
mpgn
approved these changes
Apr 25, 2024
|
Running tests now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263 by changing return value from
FalsetoNoneto match expected value, when handling errors. Also add a bit of error handling (to actually display the correct error) and string concatenation to prevent errors such as these in the future.Before:
After:
