-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mssql_priv #277
fix mssql_priv #277
Conversation
Very nice! Thanks for the fix |
Sorry I can't test right now (can in 2 days), but I think if the function that saves to res fails it's None, that's why they int'd it before, so if we just reference it it'll KeyError or whatever. I'll have to test it but if someone else can that'd be cool. |
Lol also no one (including me) noticed that the logger in the module is completely broken |
@Marshall-Hallenbeck Looks like thats just an object with "1" or "0" depending on the user being sysadmin or not |
fyi, fixed the logger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the Issue #273
The privileged user for the impersonation cannot be found, because there is an issue in the "is_admin_user" function.
Due to the try except statement the admin privileges are always wrong, because the if statement cannot be executed
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'list'
I could sucessfully test my changes on the HTB Academy module “Using CrackMapExec” in the task “MSSQL Enumeration and Attacks”