Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extract_password #279

Merged
merged 6 commits into from
Jun 1, 2024

Conversation

sepauli
Copy link
Contributor

@sepauli sepauli commented Apr 27, 2024

Fixing #278

I have changed the code so that it iterates over all entries in root and over all entries of groups and over any number of nested sub-groups and extracts and outputs the entries there and the history of the entries for Title, UserName, URL, Password and Notes.

@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Apr 27, 2024
@NeffIsBack NeffIsBack self-assigned this May 19, 2024
@NeffIsBack
Copy link
Contributor

Hi, thanks for the bug report and fix!
Unfortunately also this PR is crashing on me, as well as the main branch:
image
image

@sepauli
Copy link
Contributor Author

sepauli commented May 25, 2024

hi, sorry.
I tested it with KeepassXC and not with Keepass2. There seems to be a small difference in the XML.
I changed the output a bit and also tested it with Keepass2.
I tested it now with both versions - KeepassXC and Keepass2 - successfully

keepass2_test

Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed it thanks!
Pushed some linting fixes, LGTM now:
image

@NeffIsBack NeffIsBack merged commit 67da598 into Pennyw0rth:main Jun 1, 2024
5 checks passed
@sepauli sepauli deleted the sepauli/fix-keepass_trigger branch June 1, 2024 21:54
@mpgn mpgn added this to the v1.3.0 milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants