Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding module to retrieve network interfaces info #293

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

Sant0rryu
Copy link
Contributor

Useful to find subnets and servers for pivoting

Signed-off-by: Sant0rryu <111064983+Sant0rryu@users.noreply.github.com>
@Marshall-Hallenbeck
Copy link
Collaborator

Marshall-Hallenbeck commented May 7, 2024

@Sant0rryu thanks for the PR! Can you review the Ruff linting output by running poetry run python -m ruff check . --preview (you can add --fix to automatically fix those that it can do).

This also might be better as a default part of NXC, under the mapping/enumeration section - thoughts?

@Marshall-Hallenbeck Marshall-Hallenbeck added the enhancement New feature or request label May 7, 2024
@Dfte
Copy link
Contributor

Dfte commented May 11, 2024

Love that PR, it's gonne be super useful for network pivoting!!

Fixed Ruff checks

Signed-off-by: Sant0rryu <111064983+Sant0rryu@users.noreply.github.com>
@Sant0rryu
Copy link
Contributor Author

@Marshall-Hallenbeck I ran ruff on interface.py and fixed two warnings.

Yes, it might actually be nice to have the option --interface as a default part of NXC under the mapping/enumeration section.

@Dfte
Copy link
Contributor

Dfte commented May 13, 2024

Love the idea as well!

@NeffIsBack NeffIsBack added this to the v1.3.0 milestone May 14, 2024
@Marshall-Hallenbeck
Copy link
Collaborator

@Sant0rryu so this seems to overlap with the get_netconnections, but also as I just tried to test this, it doesn't seem to output anything. Can you confirm it's working as intended? Which Windows versions did you test against?

@NeffIsBack
Copy link
Contributor

Same here:
image

Added a bit of logging and it looks like there is a problem with the registry querying:
image

@Dfte
Copy link
Contributor

Dfte commented Jun 6, 2024

@Sant0rryu you have got news ?

@NeffIsBack NeffIsBack self-assigned this Jun 14, 2024
@NeffIsBack
Copy link
Contributor

Reworked the module to a working core functionality:
(My desktop is a bit messy due to the thousands of network adapters, vmstuff)
image

@NeffIsBack NeffIsBack merged commit cce5c32 into Pennyw0rth:main Jun 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants