Adding some logger when users have been dumped #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anhydrite
requested review from
zblurx,
Marshall-Hallenbeck,
NeffIsBack and
mpgn
as code owners
NeffIsBack
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks for the PR!
Can you also the len(users) to the samruser.py output? That way it is similar to the ldap --users flag.
Also we should leave it as .display() instead of .success() is it is informative and not really a "success" message (regarding the amount of users) imo.
|
Done ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
Just a little PR because I saw that the log "Enumerated domain users" disappeared, so i just added it back (I don't know if this was for a specific reason).
The purpose of these prints make sense when we try to enumerate local users and logged_on users. There is no separation between these two informations
And I also changed it when enumerating domain users just to make it a little consistent. There are other cases where the "-Username- -LastPwdSet-" is printed without further detail of what it is but since i do not use actively these features i prefer not touching it.
Cordially :)