Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check admin false positive on certain target (e.g Netapp) #378

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

nikaiw
Copy link
Contributor

@nikaiw nikaiw commented Jul 20, 2024

No description provided.

@nikaiw nikaiw force-pushed the check_admin_false_positive branch from 48d6969 to 7031913 Compare July 20, 2024 20:01
@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Jul 20, 2024
@NeffIsBack
Copy link
Contributor

Can you add the screenshots of before&after (of the impacted host) for documentation?

@nikaiw
Copy link
Contributor Author

nikaiw commented Jul 21, 2024

hm screenshots won't say much, would that be fine ?
Before:
image
After:
image

Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeffIsBack NeffIsBack merged commit a28c441 into Pennyw0rth:main Jul 28, 2024
5 checks passed
@mpgn mpgn added this to the v1.3.0 milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants