Fix: module spider_plus with filtered folders #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With option to filter folders is set and a folder matches the filter, there is a typo in the incremented counter.
The counter should be ` self.stats[f"num_{result_type}s_filtered"]` and not `self.stats[f"{result_type}s_filtered"]`.
The latter does not exists and trigger the following error:
```
KeyError: 'folders_filtered'
```
Signed-off-by: Guillem Lefait <guillem.lefait@gmail.com>
glefait
requested review from
zblurx,
Marshall-Hallenbeck,
NeffIsBack and
mpgn
as code owners
NeffIsBack
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With option to filter folders is set and a folder matches the filter, there is a typo in the incremented counter.
The counter should be
self.stats[f"num_{result_type}s_filtered"]and notself.stats[f"{result_type}s_filtered"].The latter does not exists and trigger the following error: