-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract obsolete operating systems from LDAP #41
Conversation
Hey, I love this idea |
@zblurx you know, that’s a great point that has not been brought to my attention before. I will update the module in an hour or so. Thanks for the good call out. but I will say, you don’t need to do any awk or grep, etc because it saves all the hostnames to a file for you already. But I get the point |
@zblurx I have made the adjustment. I also went ahead and added Server 2012 as that's less than a couple of weeks away. Finally i updated the output path from cme to nxc. |
Nice! Also it would probably be nice to give some feedback to the user about the file you are saving the output to. Something like sam and lsa dump do |
Oh my bad, missed that line. Just wanted to have the file path in some output but you already thought of that😄 |
nxc/modules/obsolete.py
Outdated
hostname_parts = answers[0][0].split('.') | ||
domain = ".".join(hostname_parts[1:]) | ||
|
||
home = Path.home() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a more conventional way to get the logs folders in NXC -> log_folder_path = os.path.join(os.path.expanduser("~/.nxc"), "logs")
Maybe adding the pwdlastset of the host? So you know it if the host is "kind a active" |
Excellent idea. I don't know if there is a more relevant LDAP attribute to see if the host is still active so this one can be good. |
@evildrummer @zblurx Excellent ideas, I will look into this later today ! |
@Shad0wC0ntr0ller |
@Shad0wC0ntr0ller can you update the single quote usage to be double quotes, and also add this module to the e2e tests command file ( |
@Shad0wC0ntr0ller any update on this? |
Sorry guys been busy with other things, ill get this handled by EOD today |
Awesome, but no pressure, justed wanted to check :) |
@Shad0wC0ntr0ller did you want to get this up to date and working? We'd like to include it in the v1.2 release if you have time :) |
I will try to make the needed updates over the next couple of days. Thank you |
Sorry for the delay, I have updated the script it will now include the pwdlastset variable. let me know if there's any more adjustments you would like to see. thank you |
583cd83
to
45258c5
Compare
Signed-off-by: Shad0wC0ntr0ller <90877534+Shad0wC0ntr0ller@users.noreply.github.com>
Updated separator in output Signed-off-by: Shad0wC0ntr0ller <90877534+Shad0wC0ntr0ller@users.noreply.github.com>
change cme to nxc Signed-off-by: Shad0wC0ntr0ller <90877534+Shad0wC0ntr0ller@users.noreply.github.com>
Added Server 2012 to the vuln list Signed-off-by: Shad0wC0ntr0ller <90877534+Shad0wC0ntr0ller@users.noreply.github.com>
Add pwdLastSet Signed-off-by: Shad0wC0ntr0ller <90877534+Shad0wC0ntr0ller@users.noreply.github.com>
change ' to " Signed-off-by: Shad0wC0ntr0ller <90877534+Shad0wC0ntr0ller@users.noreply.github.com>
Signed-off-by: Shad0wC0ntr0ller <90877534+Shad0wC0ntr0ller@users.noreply.github.com>
45258c5
to
56ef949
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition! Thanks again for you work
@Shad0wC0ntr0ller hello, can you explain when this info can help? |
@enj5oy it was a request from me. In PenTests you always check fir legacy or unsupported systems for the client. |
Extract enabled obsolete operating systems from LDAP
nxc ldap dcip -u user -p password -M obsolete