Make --version switch universal so help2man will work properly #417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the
--version
switch is available in all modes so thathelp2man
processing will function properly.--version
switch into generic_parser--version
to the conditions that will suppress the requirement fortarget
positional argumentMotivation: The netexec package (on Kali in this case) does not include man pages. The existence of man pages is required to enable the use of the
apropos
command. Theapropos
command is used when a user is trying to think of what command they need for what they are trying to do. For example:To ensure that users are more easily able to find and adopt netexec, the project should include man pages even if the
--help
pages are exhaustive. To minimize the overhead of generating man pages, the toolhelp2man
can be used to convert the various already existing--help
pages into actual man pages. Thehelp2man
tool works best when each program section (i.e.,netexec
,netexec ftp
,netexec ldap
, etc.) accepts both--help
and--version
. This change puts the--version
switch into the universal "Generic" argument group and ensures that thetarget
positional argument is not required when the--version
switch is used.