Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module loading for ssh, vnc and ftp #447

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Fix module loading for ssh, vnc and ftp #447

merged 1 commit into from
Oct 12, 2024

Conversation

NeffIsBack
Copy link
Contributor

@NeffIsBack NeffIsBack commented Oct 12, 2024 •
edited
Loading

Before as some protocols implemented proto_flow themselves but did not properly load modules. This is fixed now

Fixes #443

@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Oct 12, 2024
@NeffIsBack NeffIsBack added this to the v1.3.0 milestone Oct 12, 2024
@NeffIsBack NeffIsBack mentioned this pull request Oct 12, 2024
Closed
@NeffIsBack NeffIsBack merged commit 9e61764 into main Oct 12, 2024
6 checks passed
@NeffIsBack NeffIsBack deleted the neff-fix-loading-modules branch October 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpgn mpgn mpgn approved these changes

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

@Marshall-Hallenbeck Marshall-Hallenbeck Awaiting requested review from Marshall-Hallenbeck Marshall-Hallenbeck is a code owner

Assignees
No one assigned
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Exception with ssh - AttributeError: 'ssh' object has no attribute 'modules'
2 participants
@NeffIsBack @mpgn