-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement s4u abuse #50
Conversation
omg. |
@zblurx can you add this to the e2e tests command file as well? |
I test it, it works (with protocol transition) BTW, I think should tell the user this attack is for constrained delegation (with protocol transition) attack @zblurx |
As @XiaoliChan suggested to me, we should also support s4u2self only: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also replace the single quotes with double quotes?
Left some comments, the rest of the code looks good👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a bunch of variable naming to conform to proper Pythonic naming, but also pointed out importing the nxc logger.
All good now I think |
There are still a few single quotes but we should probably wait until #35 is merged, a lot of it is fixed in there |
|
So for the
|
Signed-off-by: zblurx <68540460+zblurx@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added
--delegate
option to implement s4u abuse over smbThis option will do a full S4U abuse (S4U2Self + S4U2Proxy) in an automated way, allowing to use all postex functionalities of NXC 🔥