-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create get_fgpp.py #65
Conversation
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Hello @sebrink what's the diff with the module PSO ? https://github.com/Pennyw0rth/NetExec/blob/72e42e9b75c9885573eecfc3888252eb93dfba9d/nxc/modules/pso.py |
Signed-off-by: sandw1ch <se.brink15@gmail.com>
@mpgn I actually was not aware of the PSO module, so these currently do the exact same thing. There appears to be a bug in the PSO module though that it can't display if there is a policy that applies to multiple objects, see the sample output below: (see the policy titled get_fgpp:
pso:
If you'd like, I can make an update to the PSO module to fix the bug sometime tomorrow or it can potentially be replaced with the get_fgpp module, up to ya'll. |
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Your output is better imo |
Maybe name your module pso and delete the old one since bugged anyway |
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Agreed, looks better. @mpgn glad to see you here:) |
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Alright it's updated to pso, modified the description and the output to say PSO rather than fgpp. As a note, the original pso module wasn't listed in the e2e_commands.txt. |
Thank you for adding it to the e2e tests :) |
Signed-off-by: sandw1ch <se.brink15@gmail.com>
@Marshall-Hallenbeck done! |
Changed to merge into |
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Resolved the conflict, looks like running |
That's almost definitely due to the LDAP query limit of 1000 objects. My lab has less than 1000 so I didn't test for that. I'll put some logic in to catch that. Need to figure out a good way to do it without just capping the module at the first 1000 entries, but nice catch @mpgn ! |
Hum looking at the module, if a client has a pso on 7k user, the module will be unreadable |
Fixed the code for you @sebrink |
Signed-off-by: sandw1ch <se.brink15@gmail.com>
Thanks for the fix @mpgn! |
@sebrink my big refactor got merged in. Would you mind taking a look at the few conflicts? |
@sebrink any chance to fix the conflict to merge the pr ? |
…shhold is 0, as they are disabled then
@mpgn fixed everything, could you give this another review? |
@Marshall-Hallenbeck here are your format strings :) |
Initial script written by n00py, https://github.com/n00py/GetFGPP
Some sample output from my lab: