Develop #16
Merged
Develop #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not prevent unnecessary rolls yet. Required changing interface of `SteerShipToward()`, Required adding some memory code to `FlightComputer` that may best belong in some other module.
Conflicts: src/RemoteTech2/FlightComputer/FlightCore.cs
This fix consists basically only of a gimbal vectoring calculation update. The old code seemed to be from an earlier version of KSP. The bug manifested itself in a craft that would not cahnge orientation whatsoever when the Flight computer was enabled. It only started to jerk around and kept facing the orientation it was facing in. This was independent of the mode of the Flight Computer. The bug can be easily reproduced by adding the following .cfg file and using the Flight Computer on the Stayputnik probe core: @part[probeCoreSphere] { !MODULE[ModuleReactionWheel] {} } I encountered this bug while playing with the RealismOverhaul mod, which removes from the reaction wheels from essentially all early tech probes. I also fixed a divide by zero bug that crashed KSP, when using the above setup. No mod other than RT2 and the custom .cfg file mentioned above are required to reproduce the bug.
Peppie84
added a commit
that referenced
this pull request
Jul 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave a comment