-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick change to allow Smooth to compile on ESP32-S3. #170
Conversation
Thanks for the contribution, @tmiw One of the tests are failing, seems libsodium is no longer available? I've not worked with the ESP for a long while now so I'm not up to speed what has changed in the esp-idf project. |
ESP-IDF isn't recognizing libsodium but the package does still exist on Ubuntu. I checked in a tweak to the CI to only use the tags listed in https://github.com/espressif/esp-idf/tags so we'll see how that goes. |
Wasn't libsodium part of esp-idf? A version ported to work with the esp? |
Not sure. Since it was failing on "latest" before, perhaps it's some bug on Expressif's end. In any case, the CI builds are using 4.2-4.4 now, which seem to be the official releases according to their Git. Those build fine FWIW. |
I removed the requirement in CI for it to build against the latest ESP, I don't have the time to maintain that myself and since it builds against the latest official tags it'll have to do for now. |
@tmiw Please add yourself to the contributor file and we'll merge this. |
Done. |
Per https://github.com/espressif/esp-idf/blob/master/components/hal/include/hal/spi_types.h, HSPI_HOST and VSPI_HOST don't exist on ESP32-S3, causing Smooth to fail while building. This change removes all references to HSPI_HOST and VSPI_HOST in favor of SPI2_HOST and SPI3_HOST.