Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added operator== and operator!= support for IO Input and Output #98

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Added operator== and operator!= support for IO Input and Output #98

merged 4 commits into from
Oct 1, 2019

Conversation

COM8
Copy link
Contributor

@COM8 COM8 commented Oct 1, 2019

I added operator== and operator!= support for the Input and Output calsses.

PerMalmberg
PerMalmberg requested changes Oct 1, 2019
View reviewed changes
Copy link
Owner

@PerMalmberg PerMalmberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, simple yet so useful.

Could you please run uncrustify (as per the contributing.md document) or at least adjust the curly braces to match the rest of the code base?

@COM8
Copy link
Contributor Author

COM8 commented Oct 1, 2019

Whoops. Sorry, fixed it. Forgot about it 😉

@COM8 COM8 requested a review from PerMalmberg October 1, 2019 12:25
@PerMalmberg
Copy link
Owner

Nice. I'll merge this later tonight. If you want, feel free to add yourself to the list of contributors too.

@PerMalmberg PerMalmberg merged commit 52c69a4 into PerMalmberg:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerMalmberg PerMalmberg PerMalmberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@COM8 @PerMalmberg