Can't locate object method "allow_bignum" via package "JSON::XS" when using OpenTracing::Implementation->bootstrap_global_default_tracer();

[marrem]

I tested the DD implementation. First I did this:

use OpenTracing::Implementation qw(DataDog);

use OpenTracing::GlobalTracer qw ($tracer);
use OpenTracing::WrapScope qw(process);
use OpenTracing::AutoScope;

...

sub someMethod {
    OpenTracing::AutoScope->start_guarded_span();
    ... 
}

sub process {
    ...
}

That went OK. Traces being sent to DD.

Output:

imta@96fb838f3fe3:/usr/local/imta/lib/perl/CAIW/REST/Client/t$ perl OpenTracingExample.pl
---- start span context
---- start fetch context
Fetching ....
Fetching done
Processing ....
Done

But when running stuff locally, we don't always have a DD agent present. So I thought, let's use the OpenTracing::Implementation->bootstrap_global_default_tracer(); and set the environment variable PERL_OPENTRACING_IMPLEMENTATION as desired. Leaving the variable unset, we don't get ugly warnings when DD agent is not reachable.

So I did this:

use OpenTracing::Implementation;
OpenTracing::Implementation->bootstrap_global_default_tracer();

use OpenTracing::GlobalTracer qw ($tracer);
use OpenTracing::WrapScope qw(process);
use OpenTracing::AutoScope;

... 

etc 

Running the script with the PERL_OPENTRACING_IMPLEMENTATION unset, the script runs without warnings (when there is no DD agent reachable).

But when running with the variable set to 'DataDog' I get:

Output:

imta@96fb838f3fe3:/usr/local/imta/lib/perl/CAIW/REST/Client/t$ PERL_OPENTRACING_IMPLEMENTATION=DataDog perl OpenTracingExample.pl
---- start span context
---- start fetch context
Fetching ....
Fetching done
Processing ....
Done
Can't locate object method "allow_bignum" via package "JSON::XS" at /usr/local/share/perl/5.36.0/OpenTracing/Implementation/DataDog/Client.pm line 234.
	(in cleanup) Can't call method "get_context" on an undefined value at /usr/local/share/perl/5.36.0/OpenTracing/Implementation/DataDog/Client.pm line 439 during global destruction.

[marrem]

Seems like doing use OpenTracing::Implementation qw(DataDog); loads the Cpanel::JSON::XS module, which has a allow_bignum method.
Using use OpenTracing::Implementation; OpenTracing::Implementation->bootstrap_global_default_tracer(); Cpanel::JSON::XS is probably not loaded and JSON::XS is used, which hasn't got a allow_bignum.

So a temporary fix is to do a use Cpanel::JSON::XS; before use OpenTracing::Implementation;. This stops the error from occurring.

[vanHoesel]

I'm afraid we overlooked that JSON::XS does not have a allow_bignum

Probably we'll need to borrow from JSON::MaybeXS and select either Channel::JSON::XS or old-fashioned JSON::PP to exclude JSON::XS.

[vanHoesel]

I have a patch available to skip JSON::XS and will try to use Cpanel::JSON::XS in favour of JSON::PP, both supporting ->allow_bignum.

However, I find it hard to write proper test to prove correctness of this approach. I need to figure out how to bypass loading Cpanel::JSON::XS even though that is installed correctly.

[marrem]

Hoi Theo, Goed werk. Bedankt. Is die al beschikbaar op CPAN? Ik ben een heel stuk gevorderd en heb een deel van mijn code voorzien van ‘instrumentation’. Hier een voorbeeld van een (cron) script dat orders doorloopt en per order informatie ophaalt.  So far so good. Alleen omdat we een storing met een database server hadden, stuitte ik op een ander probleem. Hier de response van een webservice: { "message" : "DBI connect('database=dtatest;host=imta-proxysql-dev.dfni.nl','dta',...) failed: Can't connect to server on 'imta-proxysql-dev.dfni.nl' (115) at /usr/local/imta/lib/perl/SS/App/DBH.pm line 260.\n", "error" : "CAIW::IMTA::TriplePlayTest::IMTANGListener::AddMappingException", "status" : "500", "timestamp" : "2024-05-07T15:44:37" } Hier de response van dezelfde webservice nadat de methode via WrapScope ‘gewrapt’ is. { "timestamp" : "2024-05-07T15:46:35", "status" : "500", "message" : "Died at /usr/local/share/perl/5.36.0/OpenTracing/WrapScope.pm line 163.\n", "error" : "unknown error class" } Dus de gegooide exceptie blijft niet behouden en wordt vervangen door een ‘cryptische’ melding ergens diep uit de library. Overigens wordt hij wel netjes getoond in DataDog:  Ik ga kijken of ik kan vinden wat er fout gaan in de source. Maar als je tijd hebt, kun je daar even naar kijken. Vast bedankt. Met vriendelijke groeten, Marc Remijn Deltafiber

…

Op 7 mei 2024, om 13:58 heeft Theo van Hoesel ***@***.***> het volgende geschreven: I have a patch available to skip JSON::XS and will try to use Cpanel::JSON::XS in favour of JSON::PP, both supporting ->allow_bignum. However, I find it hard to write proper test to prove correctness of this approach. I need to figure out how to bypass loading Cpanel::JSON::XS even though that is installed correctly. — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWOB5KN6XKTNPYKTRC2XM3ZBC6XVAVCNFSM6AAAAABGLAJHEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGIZTOMZYHA>. You are receiving this because you authored the thread.