Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Update ENV variables in pmm3-aws-staging-start #2621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

PMM-7 Update ENV variables in pmm3-aws-staging-start #2621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pmm/v3/pmm3-aws-staging-start.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ pipeline {
name: 'DAYS'
)
text(
defaultValue: '-e PMM_DEBUG=1 -e ENABLE_TELEMETRY=0 -e PERCONA_TEST_PLATFORM_PUBLIC_KEY=RWTg+ZmCCjt7O8eWeAmTLAqW+1ozUbpRSKSwNTmO+exlS5KEIPYWuYdX -e PERCONA_TEST_PLATFORM_ADDRESS=https://check-dev.percona.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a problem with naming between percona/pmm#2857 and percona/pmm#2705.

We have agreed some time long ago to offer consistent names for boolean env variable that would start with ENABLE_SMTH versus DISABLE_SMTH.

Copy link
Member

@ademidoff ademidoff Apr 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we suspend this PR until we have a solution/fix.

defaultValue: '-e PMM_DEBUG=1 -e PMM_DISABLE_TELEMETRY=1 -e PMM_DEV_PERCONA_PLATFORM_PUBLIC_KEY=RWTg+ZmCCjt7O8eWeAmTLAqW+1ozUbpRSKSwNTmO+exlS5KEIPYWuYdX -e PMM_DEV_PERCONA_PLATFORM_ADDRESS=https://check-dev.percona.com',
description: '''
Passing environment variables to PMM Server Docker container is supported for PMM v2 and up.
Example: -e PERCONA_TEST_CHECKS_INTERVAL=30s -e PERCONA_TEST_TELEMETRY_DISABLE_START_DELAY=1 -e PMM_DEBUG=1
Example: -e PERCONA_TEST_NICER_API=1 -e PMM_DEV_TELEMETRY_DISABLE_START_DELAY=1 -e PMM_DEBUG=1
''',
name: 'DOCKER_ENV_VARIABLE'
)
Expand Down