Explicit S3 key #224
Merged
Explicit S3 key #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jessewiles, Thanks for your fixes to the S3 Uploader! We will be freezing the code for the next 7 days or so to stabilise the code for the 1.2.0 release during our Percona Live Europe Conference. I'll review this code after that freeze. Lastly, some code cleanup in recent PR seems to have created conflicts with this PR, could you resolve them? This might be the fixes I did to adhere to Python pep8/flake8 standards. |
jessewiles
force-pushed
the
s3-explicit-key
branch
from
d0c833c to
c392dc6
Compare
|
Fixed merge conflict due to changes in S3/init.py that happened after this PR. I'll merge this if Travis-CI passes. Thanks @jessewiles! |
Flake8 wants a newline char at the end of this file.
timvaillancourt
approved these changes
Dec 1, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for explicitly specifying the S3 storage key from the command line. Using this explicit key allows a user to specify a consistent key and leverage S3's built-in versioning.