-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change search.cpan URLs to MetaCPAN #131
base: master
Are you sure you want to change the base?
Conversation
@@ -362,7 +362,7 @@ Example: | |||
|
|||
'meta-spec' => { | |||
version => '2', | |||
url => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause breakage in merging? Should this be handled specifically in CPAN::Meta::Merge
?
lib/CPAN/Meta/Spec.pm
Outdated
@@ -391,7 +391,7 @@ For the version 2 spec, either of these are recommended: | |||
|
|||
=for :list | |||
* C<https://metacpan.org/pod/CPAN::Meta::Spec> | |||
* C<http://search.cpan.org/perldoc?CPAN::Meta::Spec> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is silly, even if it's corrected later in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did a replace and didn't notice that at my first review, hence the later fix.
Any changes should be made in a -TRIAL release first, and I would wait a little while after 5.28's release to make sure any failure reports are not mixed in with 5.28's initial tests with all of cpan. |
Status? I'm a bit surprised to see this still outstanding. Anything a non-toolchain-gang-member can do to help? |
Someone(s) need to look at all the related issues and fix them, or confirm that they are no longer problems. |
As you probably already know search.cpan.org is due to be decommissioned. While redirects will be in place for existing links, this PR changes the URLs from search.cpan to their metacpan equivalent.