Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change search.cpan URLs to MetaCPAN #131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MartinMcGrath
Copy link

As you probably already know search.cpan.org is due to be decommissioned. While redirects will be in place for existing links, this PR changes the URLs from search.cpan to their metacpan equivalent.

@@ -362,7 +362,7 @@ Example:

'meta-spec' => {
version => '2',
url => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause breakage in merging? Should this be handled specifically in CPAN::Meta::Merge?

@@ -391,7 +391,7 @@ For the version 2 spec, either of these are recommended:

=for :list
* C<https://metacpan.org/pod/CPAN::Meta::Spec>
* C<http://search.cpan.org/perldoc?CPAN::Meta::Spec>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is silly, even if it's corrected later in the PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did a replace and didn't notice that at my first review, hence the later fix.

@haarg
Copy link
Member

haarg commented May 23, 2018

See also #47 and linked tickets, 86d6f68, and ff722aa. There were a number of issues the last time this was attempted. I believe the known issues have since been fixed in newer versions of the affected modules, but I would expect there will be some other fallout.

@karenetheridge
Copy link
Member

Any changes should be made in a -TRIAL release first, and I would wait a little while after 5.28's release to make sure any failure reports are not mixed in with 5.28's initial tests with all of cpan.

@trwyant
Copy link

trwyant commented Jan 1, 2020

Status? I'm a bit surprised to see this still outstanding. Anything a non-toolchain-gang-member can do to help?

@karenetheridge
Copy link
Member

Someone(s) need to look at all the related issues and fix them, or confirm that they are no longer problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants