Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoker issue on windows - dist/IO/t/io_sock.t out of sequence #17429

Closed
atoomic opened this issue Jan 17, 2020 · 3 comments
Closed

smoker issue on windows - dist/IO/t/io_sock.t out of sequence #17429

atoomic opened this issue Jan 17, 2020 · 3 comments

Comments

@atoomic
Copy link
Member

atoomic commented Jan 17, 2020

As seen from one of the recent blead smoke https://github.com/Perl/perl5/runs/393799009
This test is failing on smoke-windows-msvc142-amd64

Either we can fix it, either we should skip it on windows and continuous integration.
I would suggest to skip it on CI using one ENV variable.

Test Summary Report
3237
-------------------
3238
../dist/IO/t/io_sock.t                                           (Wstat: 0 Tests: 24 Failed: 0)
3239
  Parse errors: Tests out of sequence.  Found (12) but expected (10)
3240
                Tests out of sequence.  Found (13) but expected (11)
3241
                Tests out of sequence.  Found (14) but expected (12)
3242
                Tests out of sequence.  Found (15) but expected (13)
3243
                Tests out of sequence.  Found (16) but expected (14)
3244
atoomic added a commit to atoomic/perl5 that referenced this issue Jan 17, 2020
Fixes Perl#17429

Test is out of sequence.
Note: ENV were set too early.
@Leont
Copy link
Contributor

Leont commented Jan 17, 2020

Either we can fix it, either we should skip it on windows and continuous integration.
I would suggest to skip it on CI using one ENV variable.

I don't think skipping it should be the first option. There's no reason to assume this issue only occurs under continuous integration, so users will probably run into it too eventually.

@Leont
Copy link
Contributor

Leont commented Mar 1, 2020

This can only be explained by the client dying between the "ok 9" and the "ok 10".

I don't think we have the error that it does with, but there are only a few possibilities.

@jkahrman
Copy link
Contributor

I've experienced this failure frequently on Windows 7 when built with VS2015 on a Windows 7 x64 host (32 bit or 64 bit Perl). Less so with earlier VS versions. Not easily reproducible when the Win7 built binaries run the test on Windows 10.

The debugging I've done suggests the problem is the not the client dying, but the second/third "$listen->accept" calls failing when the client is closing/destroying it's second/third instance of "$sock". Adding a 1 second sleep after the done/quit for "ok 10/11" (respectively) appears to avoid the failures.

This is in concert with the "some machines seem to suffer from a race condition here" sleeps.

No idea what the underlying problem is, however.

io_sock.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants