Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'v' command in 'perl -d' wont work. #18900

Closed
wants to merge 2 commits into from

Conversation

peanutsjamjam
Copy link
Contributor

When I was debugging a perl program, I found 'v' command wont work:

[peanutsjamjam] > cat hello.pl
#! /usr/bin/perl

print "hello\n";
print "world\n";
[peanutsjamjam] > perl -d hello.pl

Loading DB routines from perl5db.pl version 1.60
Editor support available.

Enter h or 'h h' for help, or 'man perldebug' for more help.

main::(hello.pl:3):     print "hello\n";
  DB<1> v
Undefined subroutine &DB::cmd_l called at /usr/local/lib/perl5/5.34.0/perl5db.pl line 6034.
 at /usr/local/lib/perl5/5.34.0/perl5db.pl line 6034.
        DB::cmd_v("v", "", 3) called at /usr/local/lib/perl5/5.34.0/perl5db.pl line 4798
        DB::cmd_wrapper("v", "", 3) called at /usr/local/lib/perl5/5.34.0/perl5db.pl line 4311
        DB::Obj::_handle_cmd_wrapper_commands(DB::Obj=HASH(0x800bdc8e8)) called at /usr/local/lib/perl5/5.34.0/perl5db.pl line 3200
        DB::DB called at hello.pl line 3
Debugged program terminated.  Use q to quit or R to restart,
use o inhibit_exit to avoid stopping after program termination,
h q, h R or h o to get additional info.
  DB<1> 

the sub cmd_l no longer exists since 10 Aug 2020
commit b7a96fc
.

I changed the name of sub 'cmd_l' to '_cmd_l_main'.

Subroutine cmd_l() no longer exists.
Now we should call cmd_l_main().
@tonycoz
Copy link
Contributor

tonycoz commented Jun 22, 2021

Thanks for fixing my mistake.

I've manually merged your changes along with a version bump and added some simple tests for 'v'

@tonycoz tonycoz closed this Jun 22, 2021
@dur-randir
Copy link
Member

@tonycoz, can you mark this for a 5.34.1 maint branch?

@tonycoz
Copy link
Contributor

tonycoz commented Jun 30, 2021

@tonycoz, can you mark this for a 5.34.1 maint branch?

Done in 45a9bbf

@choroba
Copy link
Contributor

choroba commented Oct 4, 2021

See #19171 for a proper fix with a test.

But I forgot to rebase my blead, sorry. Fixing it.

Fixed.

choroba added a commit to choroba/perl5 that referenced this pull request Oct 4, 2021
cmd_l was still mentioned in the documentation and comments. Also,
there was no test for the "v" command which would test Perl#18900.
choroba added a commit to choroba/perl5 that referenced this pull request Oct 4, 2021
cmd_l was still mentioned in the documentation and comments. Also,
there was no test for the "v" command which would test Perl#18900.
choroba added a commit to choroba/perl5 that referenced this pull request Oct 4, 2021
cmd_l was still mentioned in the documentation and comments. Also,
there was no test for the "v" command which would test Perl#18900.
choroba added a commit to choroba/perl5 that referenced this pull request Oct 4, 2021
cmd_l was still mentioned in the documentation and comments. Also,
there was no test for the "v" command which would test Perl#18900.
choroba added a commit to choroba/perl5 that referenced this pull request Oct 6, 2021
cmd_l was still mentioned in the documentation and comments. Also,
there was no test for the "v" command which would test Perl#18900.
@lembark
Copy link

lembark commented Feb 12, 2022

Q: Any possibility of getting the fixed PM? Or 5.34.1 with a working debugger?

@jkeenan
Copy link
Contributor

jkeenan commented Feb 13, 2022

@tonycoz, can you mark this for a 5.34.1 maint branch?

Done in 45a9bbf

@tonycoz, you marked this issue Closed on June 22 and put a "backport-5.34" label on it on June 30. But then there were subsequent commits from @choroba. So I'm confused as to where things stand.

@steve-m-hay, once we get the questions above clarified, what are the prospects for getting this fix into a perl-5.34.1 maintenance release?

@choroba
Copy link
Contributor

choroba commented Feb 13, 2022

My changes are not essential, just fixes to the documentation and comments.

@steve-m-hay
Copy link
Contributor

@tonycoz, can you mark this for a 5.34.1 maint branch?

Done in 45a9bbf

@tonycoz, you marked this issue Closed on June 22 and put a "backport-5.34" label on it on June 30. But then there were subsequent commits from @choroba. So I'm confused as to where things stand.

@steve-m-hay, once we get the questions above clarified, what are the prospects for getting this fix into a perl-5.34.1 maintenance release?

This fix is now in the voting file for 5.34.1, which I hope to release soon. See https://perl5.git.perl.org/perl5.git/commit/45a9bbf39520e5f9fa604855fcffe2cb097fbdac

@lembark
Copy link

lembark commented Feb 23, 2022

I'm trying to convince a company to upgrade from 5.10.1 to 5.34. Having a working debugger would be helpful in convincing them to upgrade -- and continue using Perl at all.

@richardleach
Copy link
Contributor

For the historical record, this did go into 5.34.1 - in b7a355b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants