dist/threads/shared.pm - use attributes.pm explicitly #20157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems it is possible that we load the attributes XS code without loading the .pm code first. This causes threads/t/kill.t to die with an error about XS version mismatch. Explicitly loading the attributes module from threads::shared seems to fix the problem. This resolves #20155.
demerphq
force-pushed
the
yves/fix_20155_thread_shared_attributes
branch
from
5cccb6e to
ab4d487
Compare
|
I don't think this is an appropriate fix. Loading |
|
On Thu, 25 Aug 2022 at 17:47, Graham Knop ***@***.***> wrote:
I don't think this is an appropriate fix. Loading attributes late (as
triggered by the :shared attribute in kill.t) should not cause an error.
Ok, thanks. That is useful. Then I will keep digging into why the XS
bootstrap code (attributes.so) is being loaded directly before the perl
code (attributes.pm) has executed.
Yves
--
perl -Mre=debug -e "/just|another|perl|hacker/"
|
|
Since it's now clear that this is a much bigger (and more generic) issue I think the PR can be dropped/closed.. |
|
agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems it is possible that we load the attributes XS code
without loading the .pm code first. This causes threads/t/kill.t to
die with an error about XS version mismatch. Explicitly loading
the attributes module from threads::shared seems to fix the problem.
This resolves #20155.