feature.pm add __END__, split POD, less IO/CPU parse time #22700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
reviewed
Nov 6, 2024
Comment on lines
-127
to
+128
|
|
||
| L<XXX> has been upgraded from version A.xx to B.yy. | ||
| =item feature.pm | ||
|
|
||
| XXX If there was something important to note about this change, include that here. | ||
| L<feature.pm|/feature.pm> has been upgraded from version 1.91 to 1.92. Split POD and code |
There was a problem hiding this comment.
This looks like bad formatting. It should be:
=item *
L<feature> has been upgraded ...
-feature.pm is 29 KB big, don't IO read or parse 22 KB of POD feature.pm's POD in the middle is from its initial commit 69bcf1d 12/22/2011 1:46:41 AM Create regen/feature.pl
mauke
force-pushed
the
feature_pm_dont_parse_22KB_POD
branch
from
074f6a8
to
5a5b8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-feature.pm is 29 KB big, don't IO read or parse 22 KB of POD
feature.pm's POD in the middle is from its initial commit
69bcf1d 12/22/2011 1:46:41 AM Create regen/feature.pl