fix refassign in non-void context #22938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH #22710 The experimental refassign feature, \@A = $aref, which allows an array/hash etc to be aliased rather than copied, got broken in rvalue non-void context by v5.39.5-56-g604c0355d2. So in something like my $x = (\@A = $aref); the stack was underflowing. This is because previously pp_refassign() would leave its RH argument on the stack when returning, while my commit above made it always pop the argument off the stack. This commit makes it only pop the arg in void context.
mauke
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH #22710
The experimental refassign feature, @A = $aref, which allows an array/hash etc to be aliased rather than copied, got broken in rvalue non-void context by v5.39.5-56-g604c0355d2. So in something like
the stack was underflowing. This is because previously pp_refassign() would leave its RH argument on the stack when returning, while my commit above made it always pop the argument off the stack.
This commit makes it only pop the arg in void context.