Skip to content

Improve documentation of sv_dup and sv_dup_inc #23454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2025
Merged

Improve documentation of sv_dup and sv_dup_inc #23454

merged 2 commits into from
Jul 20, 2025

Conversation

Leont
Copy link
Contributor

@Leont Leont commented Jul 20, 2025

This is a follow-up on #22291

This reverts marking these functions as core-only. They really need to be API because it's often impossible to write thread-safe XS modules without them.

I've added an explanation of when exactly you need these functions, without that it's rather unclear when you'd need them (and when not).

This also clarifies that the pointer table is in fact not a cache, but an essential element of the cloning process. Without it, an non-incremented sv_dup wouldn't even make sense (something else would need to dup and increment it).

I haven't touched the last paragraph because that needs #23325 to be resolved first.

  • This set of changes does not require a perldelta entry.

@Leont Leont requested a review from khwilliamson July 20, 2025 15:03
@Leont Leont merged commit 83b32ab into blead Jul 20, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants