perlrebackslash: Fix false statements #23688
Open
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean that the regular expression |
|
It does. Wow. |
book
approved these changes
Sep 6, 2025
Prior to this commit, it was claimed that certain sequences should not occur in regular expression pattern bracketed character classes. I tried each one changed here, and they worked fine.
khwilliamson
force-pushed
the
rebackslash
branch
from
180fa94 to
436e4bc
Compare
|
@book, I did some more experiments, and changed the text for \Q and \E accordingly since your approval |
Do we already have unit tests in our test suite which verify the behavior which you are now documenting? If not, we should write such tests. |
|
The experiments should be turned into tests, basically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was claimed that certain sequences should not occur in regular expression pattern bracketed character classes. I tried each one changed here, and they worked fine.