Avoid some UTF8SKIPs #23695
Open
Avoid some UTF8SKIPs #23695
+35
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
force-pushed
the
rm_utf8skips
branch
from
e9eaeea to
9f6f8a5
Compare
tonycoz
reviewed
Sep 10, 2025
| @@ -730,7 +730,7 @@ S_warn_expect_operator(pTHX_ const char *const what, char *s, I32 pop_oldbufptr) | |||
| const char *t= oldbp; | |||
| assert(s >= oldbp); | |||
| while (t < s && isSPACE(*t)) { | |||
| t += UTF ? UTF8SKIP(t) : 1; | |||
There was a problem hiding this comment.
Line 707 too.
Wouldn't t++ be more typical than t += 1? (below too)
There was a problem hiding this comment.
Line 707 too.
nm, it's in #23698
There was a problem hiding this comment.
Nonetheless, I shouldn't be introducing non-idiomatic code at all. Changed
This value is returnable from the called function. Use it instead of re-deriving it
This value is returnable from the called function. Use it instead of re-deriving it
This value is returnable from the called functions. Use it instead of re-deriving it
If a character matches isSPACE, it must be an ASCII character, and hence its length is 1. No need check for and call UTF8SKIP on it.
This value is returnable from the called functions. Use it instead of re-deriving it
khwilliamson
added
the
Use merge commit
khwilliamson
force-pushed
the
rm_utf8skips
branch
from
8ade822 to
ea90d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value is returnable from the called functions. And those functions have actually verified every byte that comprises the code point, so it is safer and better practice to use this value, instead of UTF8SKIP, which looks just at the first byte.