Add regression tests for GH-23816 #23820
Closed
+86
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test file consists of sets of nested 'for' loops. The closing braces of the loops in two of those sets were on the same line, which made the code less legible. To uncuddle them, we eat our own dogfood and convert two heredocs to indented heredocs.
|
#22938 (which was merged) already includes a similar regression test. |
|
Closing as request already satisfied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two regression tests for #23816
This p.r. consists of two commits, the first of which was written solely to do some tidying of
t/op/decl-refs.t. That tidying enabled me, for the first time, to use an indented here-doc in the core distribution.The second commit is actually the regression test. Once I wrote it, I realized that the tidying in the first commit was not absolutely essential, but I'm leaving it here on the "eat your own dogfood" principle.