Move tests to t/lib/croak/signatures
#23826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a test file to begin with a common pragma line or other setup code and avoid having to repeat that setup across every individual test block in the file.
It's better to reuse the standard croak test infrastructure, than put lots of ad-hoc uses of `eval` and assertions on the value of `$@` afterwards in the regular signatures.t file.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to add a bunch more croak tests as part of the
signatures-named-paramsbranch, and was somewhat surprised to find we don't already use a file like this for that purpose. So I moved all the manualeval and look at $@tests out of signatures.t into this new file.