pp_ctl.c: comment on unreachable code #23965
Closed
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iabyn
reviewed
Nov 27, 2025
Contributor
iabyn
left a comment
iabyn
left a comment
There was a problem hiding this comment.
Given that its not slowing anything down by being there, I would be tempted to keep in case of any hypothetical XS-constructed optrees which bypass the compile-time check.
Test suite does not reach this code block, but Dave M recommends retaining it in case of (hypothetical) XS-constructed optrees which bypass compile-time check. For: GH Perl#23964 (issue); GH Perl#23965 (p.r.)
Contributor
Author
Okay, since I'm mainly concerned with clearing away the underbrush for #23618, I'll revert the code and include an inline comment. |
jkeenan
force-pushed
the
pp_ctl-c-remove-unreachable-code-20251126
branch
from
8f53576 to
6f60178
Compare
tonycoz
reviewed
Nov 30, 2025
jkeenan
added
the
squash-before-merge
jkeenan
changed the title
Contributor
Author
|
This p.r. was superseded by #23971. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #23964.