Fix reference-counting in set_event_filter #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue happens for me when upgrading SDL2 from 2.28.5 to 2.30.1. I build Perl SDL against sdl12-compat-1.2.68 which is a wrapper around SDL2. I confirm that this patch fixes my test failure. |
ppisar
reviewed
Apr 2, 2024
This previously resulted in the following test failure with Perl 5.38.2 on Debian unstable (https://bugs.debian.org/1064761): t/core_events.t ................. 1/? Can't use an undefined value as a subroutine reference during global destruction. t/core_events.t ................. Dubious, test returned 22 (wstat 5632, 0x1600) All 691 subtests passed (less 1 skipped subtest: 690 okay)
cjwatson
force-pushed
the
event-filter-refcount
branch
from
db0fc61 to
fbf151a
Compare
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Apr 17, 2024
https://build.opensuse.org/request/show/1168524 by user dstoecker + dimstar_suse - Add 308.patch: Fix reference-counting in set_event_filter (gh#PerlGameDev/SDL#308).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously resulted in the following test failure with Perl 5.38.2 on Debian unstable (https://bugs.debian.org/1064761):