Integrate folder caching into web-app #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Random note about some code changes. I opened #385 pretty recently, but I actually ended up using lodash here since it was available and I wanted to check deep equality between FolderVOs to prevent rerenders. So maybe we should just close that issue for now? |
meisekimiu
requested review from
crisnicandrei,
cecilia-donnelly and
liam-lloyd
meisekimiu
force-pushed
the
folder-caching-implementation
branch
from
8be9f57
to
e4a1286
Compare
liam-lloyd
approved these changes
Apr 26, 2024
meisekimiu
force-pushed
the
folder-caching-implementation
branch
3 times, most recently
from
3afed8e
to
bdb3e70
Compare
meisekimiu
force-pushed
the
folder-caching-implementation
branch
from
bdb3e70
to
bfe2ab6
Compare
Wrap the PermanentFilesystem in a new service so that it can be used throughout the application. Then use it throughtout the application where we are fetching folders. PER-9468: Integrate filesystem caching system (folder navigate)
The FileListComponent would refresh the folder contents after it was initialize. This is not necessary since it is handled by the PermanentFilesystem now. PER-9468: Integrate filesystem caching system (folder navigate)
A flash of unloaded thumbnails would sometimes be visible when navigating to folders since the behind-the-scenes cache update would end up triggering a rerender of the file list. Prevent this by only triggering an update to these values when the fetched folder differs from the cached value. PER-9468: Integrate filesystem caching system (folder navigate)
This file doesn't have the prettier format pragma on it. Also it has some unused imports. Get rid of them too. PER-9468: Integrate filesystem caching system (folder navigate)
Auto fixed with eslint
The RecordVO constructor was changed in commit a1f3250. Update the call to the constructor in the FolderVO constructor. PER-9468: Integrate filesystem caching system (folder navigate)
meisekimiu
force-pushed
the
folder-caching-implementation
branch
from
bfe2ab6
to
3a64b86
Compare
k8lyn6
approved these changes
May 7, 2024
There was a problem hiding this comment.
Followed your instructions @meisekimiu and everything looked good to me! And share and public folders are working as expected too. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR actually integrates the previously hidden PermanentFilesystem class into the application. This is done by creating the
PermanentFilesystemService, a wrapper service that allows this functionality to be imported into other modules across the application. The service also provides the proper implementation of theFilesystemApiinterface, which wraps around theApiServiceand processes theFolderResponseautomatically.Steps to test:
navigateLeanresponse has not finished.navigateAPI calls, or large shifts in UI after the API calls finish.