List all accepted archives at end of Glam onboarding #491
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
+ Coverage 42.65% 42.73% +0.08%
==========================================
Files 359 360 +1
Lines 10974 10986 +12
Branches 1793 1794 +1
==========================================
+ Hits 4681 4695 +14
- Misses 6133 6134 +1
+ Partials 160 157 -3 ☔ View full report in Codecov by Sentry. |
|
The 1 line of missing coverage is an angular module constructor, which I think is fine to leave uncovered. |
| <div> | ||
| <img | ||
| src="/assets/svg/onboarding/default-archive.svg" | ||
| alt="Custom Archive Icon" |
There was a problem hiding this comment.
This didn't change, but is this useful alt text?
There was a problem hiding this comment.
It probably isn't and it might be better to use an aria-labeledby attribute instead here!
There was a problem hiding this comment.
Step 1 Testing Comments:
I am unable to see my newly created archive on the screen. Please see image below. After I hit "next" on this screen, it shows the updated screen with my archive listed.
Step 2 Testing Comments:
- Move paragraph text "You've been invited to..." to right hand side, above archive list.
- "accept" button is not functional
Screen.Recording.2024-11-21.at.12.12.03.PM.mov
|
@meisekimiu is there anything you are waiting on from me or @yeslikesolo for this? Just wanted to check! |
meisekimiu
force-pushed
the
glam-onboarding-all-accepted-archives
branch
from
4521a87
to
2d94f04
Compare
|
As for the accept button issue, I'm not sure that's connected to this PR and it might be a network or other strange environment issue. Can we try testing that again? It seems to work when I test on a newly reset local development environment as well as on Staging. |
|
Hey @meisekimiu , my apologies but I think the text on the "Welcome with archive invitations" page should go wherever it indicates in the design. If it's on the left side, then we should keep it there. cc @yeslikesolo can you test whether the accept button is still not functional for you? |
meisekimiu
force-pushed
the
glam-onboarding-all-accepted-archives
branch
from
e088d61
to
44ad466
Compare
|
@k8lyn6 @meisekimiu hmm that's weird, maybe I'm looking at an outdated design file? Because its on the right side for me. Either way, whichever is fine! I was following the design file that I thought was the source of truth. |
|
|
There was a problem hiding this comment.
I know @meisekimiu flagged she already fixed the small text - just wanted to note it here too!
Screen.Recording.2024-12-04.at.11.29.32.AM.mov
Accept button worked when I first hit accept. I then hit "create new archive", decided to go back to previous screen, and now the accept button is no longer working. Please see screen recording above.
The onboarding flow(s) used in the app tend to involve a lot of small components passing data to each other. This communication can be simple and lightweight, but as components and flows grow in complexity this becomes harder to manage. Fortunately we can use Angular services as a way to refactor this code. Create the OnboardingService that stores created/accepted archives so we can show them back to the user in the final screen without having to differentiate between created and accepted archives. While it's unclear if just this refactoring requires a whole service, there have been many occurences where consolidating onboarding code into a central service would have been useful in the past few months. So while the implementation of this service leaves a lot to be desired, this is at least a good first step towards moving more of the onboarding flow's behavior into this service instead of components. This in turn would allow us to redesign the onboarding flow in the future without worrying about damaging fundamental onboarding behavior. PER-9891: Final glam onboarding screen should list all accepted archives
Get finalized archives from the OnboardingService to display in the `pr-finalize-archive-creation-screen` component and update the component to iterate over a list of archives instead of just displaying the name. This also means updating the component so access role is not hardcoded to list "OWNER". PER-9891: Final glam onboarding screen should list all accepted archives
If a user hits the "approve" button, use the new OnboardingService to remember this if the user hits back during the process. Also, adjust how archives are added to the service so that a user can accept archives AND create a new archive, and all archives are present at the end of the list. PER-9891: Final glam onboarding screen should list all accepted archives
meisekimiu
force-pushed
the
glam-onboarding-all-accepted-archives
branch
from
deaae15
to
06ac92f
Compare
Right now the final congratulations / "finalize" screen lists a user's created archive. If a user has archive invites they can accept multiple archives during onboarding but only one is showing and it is listed as an owner regardless of the access role of the archive. Update this congrats screen to handle multiple archives and list out all their access roles correctly.
This PR involves the creation of a new
OnboardingServicewhich mainly acts as a place to store "registered archives" and then get that final list of archives in the end. This is a better pattern for sharing information between components with complex flows compared to the Input/Output system we're using now, but I also think that the onboarding flow has complex enough behavior to warrant some of that behavior moving into a dedicated service anyway. I didn't want this 1 point ticket to involve a complete refactoring of glam onboarding logic, so this service is pretty bare right now. As we continue to improve the onboarding flow, I hope we can continue to move things into this service.Steps to test:
This can be tested through the onboarding Storybook demo by running
npm run storybook.