Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PER-9922 Show loading spinner and success message checkout #496

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

crisnicandrei
Copy link
Contributor

Steps to test:
1 Go to the storage modal
2. Buy some storage
3. A loading spinner and a success message should appear

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.10%. Comparing base (d7a7841) to head (e7d333f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...edge/components/new-pledge/new-pledge.component.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   43.05%   43.10%   +0.05%     
==========================================
  Files         362      362              
  Lines       11035    11042       +7     
  Branches     1799     1799              
==========================================
+ Hits         4751     4760       +9     
+ Misses       6124     6122       -2     
  Partials      160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const displayedMessage = find('.success-message');

expect(displayedMessage.nativeElement.textContent).toContain(
'Success! 5 GB of Permanent storage has been added to your account.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems a bit too specific, ideally it should only check that .success-message exists and that the text content features the amount of GB added. Otherwise if it's too specific we'll end up with a failing test if we want to reword things later.

@crisnicandrei
Copy link
Contributor Author

@meisekimiu thanks, makes sense! Changed the test!

Copy link

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

Rewrite the test to check for the html component instead of the message displayed.
@crisnicandrei crisnicandrei force-pushed the PER-9922-show-loading-spinner-storage-checkout branch from 2fbd6a6 to e7d333f Compare December 9, 2024 17:04
@crisnicandrei crisnicandrei merged commit 7ac75ae into main Dec 9, 2024
4 checks passed
@crisnicandrei crisnicandrei deleted the PER-9922-show-loading-spinner-storage-checkout branch December 9, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants