-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PER-9922 Show loading spinner and success message checkout #496
PER-9922 Show loading spinner and success message checkout #496
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 43.05% 43.10% +0.05%
==========================================
Files 362 362
Lines 11035 11042 +7
Branches 1799 1799
==========================================
+ Hits 4751 4760 +9
+ Misses 6124 6122 -2
Partials 160 160 ☔ View full report in Codecov by Sentry. |
const displayedMessage = find('.success-message'); | ||
|
||
expect(displayedMessage.nativeElement.textContent).toContain( | ||
'Success! 5 GB of Permanent storage has been added to your account.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test seems a bit too specific, ideally it should only check that .success-message
exists and that the text content features the amount of GB added. Otherwise if it's too specific we'll end up with a failing test if we want to reword things later.
@meisekimiu thanks, makes sense! Changed the test! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks!
Rewrite the test to check for the html component instead of the message displayed.
2fbd6a6
to
e7d333f
Compare
Steps to test:
1 Go to the storage modal
2. Buy some storage
3. A loading spinner and a success message should appear