PER-9922 Show loading spinner and success message checkout #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 42.71% 42.74% +0.03%
==========================================
Files 359 359
Lines 10974 10981 +7
Branches 1793 1793
==========================================
+ Hits 4687 4694 +7
- Misses 6128 6130 +2
+ Partials 159 157 -2 ☔ View full report in Codecov by Sentry. |
meisekimiu
reviewed
Dec 3, 2024
| const displayedMessage = find('.success-message'); | ||
|
|
||
| expect(displayedMessage.nativeElement.textContent).toContain( | ||
| 'Success! 5 GB of Permanent storage has been added to your account.', |
There was a problem hiding this comment.
This test seems a bit too specific, ideally it should only check that .success-message exists and that the text content features the amount of GB added. Otherwise if it's too specific we'll end up with a failing test if we want to reword things later.
Rewrite the test to check for the html component instead of the message displayed.
|
@meisekimiu thanks, makes sense! Changed the test! |
meisekimiu
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test:
1 Go to the storage modal
2. Buy some storage
3. A loading spinner and a success message should appear