-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background to FamilySearch Import Modal #497
base: main
Are you sure you want to change the base?
Conversation
Ideally this would be testable in Storybook but these components were not designed to be mocked very easily and efforts to put them in a Storybook story only eneded in strange errors. PER-9917: FamilySearch Import Modal Broken
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
- Coverage 42.65% 42.62% -0.03%
==========================================
Files 359 360 +1
Lines 10974 10986 +12
Branches 1793 1794 +1
==========================================
+ Hits 4681 4683 +2
- Misses 6133 6146 +13
+ Partials 160 157 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @meisekimiu it looks like the modal doesn't scroll and goes off the page right now, at least on Chrome. I'm not able to see the full list, and there's no "submit" button or anything. See screenshot. I'd love for this to go out in tomorrow's deployment if we're able to do it, but it's okay if not!
@yeslikesolo once Natalie has made changes, can you take over QA for this? You have to deploy to staging because we can't test FamilySearch on dev. To deploy to staging, you build the branch just like you would on dev, just in the "Staging Build" tab. Then you'll have to manually deploy it yourself on the infrastructure page. Ping me if you have questions about it!
Previously this probably scrolled but with the new dialog changes scrolling needed to be added to the dialog. To make things flow better, add a scroll bar in the middle of the dialog so that the prompt ("select family members") and the buttons are always visible while a user is choosing something. PER-9917: Fix FamilySearch Modal
Add a background to the FamilySearch Import Modal, since it only had a transparent background. This was a style breakage caused by our migration to thew new CDK dialog.
Ideally this would be testable in Storybook but these components were not designed to be mocked very easily and efforts to put them in a Storybook story only ended in strange errors.
Steps To Test: