Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background to FamilySearch Import Modal #497

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

meisekimiu
Copy link
Member

Add a background to the FamilySearch Import Modal, since it only had a transparent background. This was a style breakage caused by our migration to thew new CDK dialog.

Ideally this would be testable in Storybook but these components were not designed to be mocked very easily and efforts to put them in a Storybook story only ended in strange errors.

Steps To Test:

  1. Go to apps and connect to FamilySearch
  2. Import a family tree
  3. Verify that all modals, in all steps of the process, have a background

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.73%. Comparing base (dd219e5) to head (ce9c5cb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   42.78%   42.73%   -0.05%     
==========================================
  Files         360      360              
  Lines       10986    10986              
  Branches     1794     1794              
==========================================
- Hits         4700     4695       -5     
- Misses       6128     6132       +4     
- Partials      158      159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yeslikesolo yeslikesolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried connecting a familysearch account and keep running into this screen. I've tried making new permanent accounts on dev and link the new account, but each time I end up at this same screen.

image

Copy link

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meisekimiu it looks like the modal doesn't scroll and goes off the page right now, at least on Chrome. I'm not able to see the full list, and there's no "submit" button or anything. See screenshot. I'd love for this to go out in tomorrow's deployment if we're able to do it, but it's okay if not!
Screenshot 2024-12-04 at 5 58 13 PM

@yeslikesolo once Natalie has made changes, can you take over QA for this? You have to deploy to staging because we can't test FamilySearch on dev. To deploy to staging, you build the branch just like you would on dev, just in the "Staging Build" tab. Then you'll have to manually deploy it yourself on the infrastructure page. Ping me if you have questions about it!

@meisekimiu
Copy link
Member Author

Screenshot from 2024-12-05 09-12-45
I added a scrollbar to the middle of the modal so that the "Select Person(s) To Import" text and the buttons are always visible even if there's a long list of members.

Copy link

@yeslikesolo yeslikesolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved! Sorry I clicked the wrong button >.<

Ideally this would be testable in Storybook but these components were
not designed to be mocked very easily and efforts to put them in a
Storybook story only eneded in strange errors.

PER-9917: FamilySearch Import Modal Broken
Previously this probably scrolled but with the new dialog changes
scrolling needed to be added to the dialog. To make things flow better,
add a scroll bar in the middle of the dialog so that the prompt ("select
family members") and the buttons are always visible while a user is
choosing something.

PER-9917: Fix FamilySearch Modal
@meisekimiu meisekimiu merged commit 42fbea4 into main Dec 5, 2024
4 checks passed
@meisekimiu meisekimiu deleted the familysearch-modal-fix branch December 5, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants