Call v2 version of registerRecord on all uploads #498
Merged
+182
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
+ Coverage 42.78% 42.95% +0.17%
==========================================
Files 360 360
Lines 10986 10985 -1
Branches 1794 1793 -1
==========================================
+ Hits 4700 4719 +19
+ Misses 6130 6107 -23
- Partials 156 159 +3 ☔ View full report in Codecov by Sentry. |
liam-lloyd
approved these changes
Dec 4, 2024
meisekimiu
force-pushed
the
v2-registerrecord
branch
from
eb96928
to
ddc517a
Compare
k8lyn6
approved these changes
Dec 5, 2024
We previously only used this for multipart uploads. Migrate to the V2 version of this endpoint. PER-9931: Use V2 requests in all calls to /registerRecord
Add a basic test that runs through the expected single-part upload flow in the Uploader class. This does not cover the entire class, but does cover the changes made in this pull request. PER-9931: Use V2 request for registerRecord
meisekimiu
force-pushed
the
v2-registerrecord
branch
from
ddc517a
to
577fa7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only used this for multipart uploads. Migrate to the V2 version of this endpoint.
Steps to test: