-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6 list persistance #11
Conversation
I think the current "eager" system should be fine for now. We can optimize later if we need. For |
This reverts commit bd8346b.
…needs a little cleaning.
Removed createListModel and createItem and replaced by with putListModel and putItem. add was renamed to addOrUpdate Finally, I change the remove and addOrUpdate functions in such a way so that they are now responsible for deleting and putting items to the database as well as creating links to them. Love to hear thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality is still working great! Just a few code-cleanup things I saw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good!
Here is a design overview:
Some design questions/concerns: