Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DEFAULT_INIT_SHELL to /sbin/openrc-run for Gentoo and Alpine #1

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

Peter-Levine
Copy link
Owner

Gentoo and Alpine always set the rc init scripts' shebang to #!/sbin/openrc-run, whether or not openrc is installed.

Motivation and Context

Fixes openzfs#12683

Description

Unconditionally sets DEFAULT_INIT_SHELL="/sbin/openrc-run" for Gentoo and Alpine to ensure the correct shebang is always used regardless of build-time availability of openrc-run.

How Has This Been Tested?

mv /sbin/openrc-run /sbin/openrc-run.old
ebuild /var/db/repos/gentoo/sys-fs/zfs/zfs-2.1.1-r2.ebuild unpack.
Edited /var/tmp/portage/sys-fs/zfs-2.1.1-r2/work/zfs-2.1.1/config/zfs-build.m4 to reflect changes in this PR.
ebuild /var/db/repos/gentoo/sys-fs/zfs/zfs-2.1.1-r2.ebuild merge.
Confirmed correct shebang.
mv /sbin/openrc-run.old /sbin/openrc-run

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Gentoo and Alpine always set the rc init scripts' shebang to
#!/sbin/openrc-run, whether or not openrc is installed.

Signed-off-by: Peter Levine <plevine457@gmail.com>
@Peter-Levine Peter-Levine merged commit 58a7130 into master Oct 26, 2021
@Peter-Levine Peter-Levine deleted the Peter-Levine-patch-1 branch October 26, 2021 21:20
@Peter-Levine Peter-Levine restored the Peter-Levine-patch-1 branch October 26, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openrc service files are non-functional if sys-apps/openrc isn't yet installed on the system
1 participant